Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor celery tasks + management commands #1347

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Aug 14, 2024

Some of our celery tasks are wrappers around management commands - a legacy feature of the earlier implementation:

The PR improves task logging by including the output of the management commands in the celery task results. We decided to keep the commands around for the time being because the libraries we currently use for manually triggering tasks are not maintained, so we may need to make use of the management commands after all.

@pi-sigma pi-sigma force-pushed the refactor/management-commands branch from 89fb8b5 to 3fa5a9d Compare August 14, 2024 12:36
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (8f22d47) to head (b2f7e8c).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1347      +/-   ##
===========================================
+ Coverage    95.11%   95.13%   +0.01%     
===========================================
  Files          995      998       +3     
  Lines        36472    36601     +129     
===========================================
+ Hits         34692    34819     +127     
- Misses        1780     1782       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review August 14, 2024 13:01
@pi-sigma pi-sigma requested a review from swrichards August 14, 2024 13:01
@pi-sigma pi-sigma marked this pull request as draft August 14, 2024 13:04
@pi-sigma pi-sigma marked this pull request as ready for review August 14, 2024 14:06
@pi-sigma pi-sigma force-pushed the refactor/management-commands branch from 3fa5a9d to 73a3424 Compare August 15, 2024 13:16
    - the output of django management commands is included in the
      task results which serve as wrappers for the commands
@pi-sigma pi-sigma force-pushed the refactor/management-commands branch from 73a3424 to b2f7e8c Compare August 15, 2024 13:18
@pi-sigma pi-sigma requested a review from swrichards August 15, 2024 15:02
@swrichards swrichards requested a review from alextreme August 15, 2024 15:18
@alextreme alextreme merged commit acc6853 into develop Aug 15, 2024
18 checks passed
@alextreme alextreme deleted the refactor/management-commands branch August 15, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants