[#2261, #2262, #2263] Fix display name in profile

[pi-sigma]

• Use display name ("roepnaam") in profile welcome message by default
• Use first name as fallback in case roepnaam is not set
• Show roepnaam in profile overview

Taiga: #2261, #2262, #2263

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (69630e7) to head (6ef9f62).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1342   +/-   ##
========================================
  Coverage    95.09%   95.10%           
========================================
  Files          994      994           
  Lines        36244    36248    +4     
========================================
+ Hits         34468    34472    +4     
  Misses        1776     1776           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[swrichards]

This is mildly confusing because display_name is used elsewhere (e.g. in the profile edit page) to signify the Dutch word "roepnaam", which this would replicate. Perhaps addressable_name to indicate its purpose in addressing the user?

[pi-sigma]

What do you find confusing about call_name? It doesn't replicate display_name because it returns either the display_name (if it's set) or the first_name. Am I missing something?

[swrichards]

I found it confusing that they refer to the same concept, e.g. the code here, which suggests that we treat display_name as equal to "Roep Naam".

Differently put, I think our names should actually be reversed:

• The model field display_name should be call_name
• The property here should be display_name

But: given that this is slated for deprecation, let's not worry about it and move forward with this.

[pi-sigma]

Now I get it. I stumbled over this myself and couldn't come up with a great name, since "display_name" would already be appropriate.