Backported Docker and Celery fixes #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added os upgrade to be sure the libraries as up to date as possible everytime the image is built. - Replaced vim with nano - Used uv instead of pip (super fast drop in replacement) - Compile translatable messages during build - Added proper release scheme attributes - Separated Celery into worker, beat and monitor containers - Added additional health checks to steer the ordering of container-startup There was 1 container reserved for all Celery related things: worker, beat and monitoring. According to Celery documentation it's best to have a separate Beat process so you can scale separately. Also, combining monitoring with the events itself could cause issues. Everything is separated now. Additional health checks and dependancies are introduced to Docker-compose so Celery nicely waits for the database to be prepped.
- The notifications-api-common library interferes with Celery's task
loading mechanism, which prevents tasks form our apps from showing
up in the admin. The temporary fix is to load the library after all
our apps
The Celery docs make clear that the name parameter of the task decorator should be unique and that generally it functions as an identifier the task. From this we can also infer that names that change at runtime, due to gettext, are undesirable. This in fact created issue with triggering certain periodic tasks in the admin, due to a mismatch between the registered name (English) and the translated name used at runtime (Dutch). TLDR: let Celery generate the name, and directly translate the periodic task names for Beat so that the entries in the Django periodic task admin are human-readable. This is not ideal as we would like to use (lazy) gettext here, but Celery doesn't allow that, so this strikes the balance between human-readability and predictable task discovery.
e59b450 to
7e15aee
Compare
- specifying multiple package versions without separator (comma or semicolon)
is deprecated since pip 24.1
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/1.18.x #1332 +/- ##
=================================================
- Coverage 95.17% 95.16% -0.02%
=================================================
Files 981 981
Lines 35665 35685 +20
=================================================
+ Hits 33945 33958 +13
- Misses 1720 1727 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported the Docker changes from this PR to keep the changes to existing installations to a minimum.
Also backported the Celery fix, as well as the requirements fixes that were needed in 1.18 and done in develop branch.