[#dimpact-107] Hotfix for celery search task not showing in admin #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The notifications-api-common library interferes with Celery's task
loading mechanism, which prevents tasks form our apps from showing
up in the admin. The temporary fix is to load the library after all
our apps
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1316 +/- ##
========================================
Coverage 95.12% 95.12%
========================================
Files 983 983
Lines 35727 35727
========================================
Hits 33985 33985
Misses 1742 1742 ☔ View full report in Codecov by Sentry. |
swrichards
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our notifications-api-common library interferes with Celery's task loading by patching the autoretry meachanism (code), which somehow prevents tasks form our apps from showing up in the admin. The temporary fix is to load the library after all our apps.
Eventually needs to be fixed in the library itself.
Taiga: https://taiga.maykinmedia.nl/project/dimpact-enschede-ssc-ict-1/issue/107