Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#2508] Fix hotfix for non-business login tab-panel #1312

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 16, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2508

Test: http://localhost:8000/accounts/login/

If 'zakelijk'/eHerkenning is turned off, then there will be no tab-headers visible, which means no tab-panel Nodes should be rendered

fixing the console error:

Uncaught TypeError: Cannot read properties of null (reading 'addEventListener')
    at new TabPanel (open_inwoner-js.js:4704:24)
    at open_inwoner-js.js:4805:10 ...
    ...

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (0002256) to head (cd6ebe6).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1312   +/-   ##
========================================
  Coverage    95.12%   95.12%           
========================================
  Files          983      983           
  Lines        35727    35727           
========================================
  Hits         33985    33985           
  Misses        1742     1742           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin requested a review from pi-sigma July 16, 2024 18:33
@jiromaykin jiromaykin marked this pull request as ready for review July 16, 2024 19:45
@jiromaykin jiromaykin merged commit e314eaf into develop Jul 18, 2024
18 checks passed
@jiromaykin jiromaykin deleted the fix/2508-login-tab-conditional branch July 18, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants