Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [#2600] Update translations #1311

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 16, 2024

https://taiga.maykinmedia.nl/project/open-inwoner/task/2600
repeating issue: updating translations.

Delta can be seen in the .po file.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (e314eaf) to head (edc27c8).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1311   +/-   ##
========================================
  Coverage    95.12%   95.12%           
========================================
  Files          990      990           
  Lines        35769    35769           
========================================
  Hits         34026    34026           
  Misses        1743     1743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the translations/2600-update-translations branch 2 times, most recently from 318dfc5 to 9fb53f5 Compare July 16, 2024 18:36
@jiromaykin jiromaykin marked this pull request as ready for review July 18, 2024 07:43
@jiromaykin jiromaykin requested a review from swrichards July 18, 2024 07:50
@jiromaykin
Copy link
Contributor Author

@swrichards Hier de vertalingen zoals we dat doen vanuit het Manage script. Het idee is dat we in de back-end code Engels gebruiken maar in alles wat de gebruiker ziet Nederlands. Maar... we gebruiken het vertalingsbestand ook wel eens om fouten in Nederlandse teksten te corrigeren. En je ziet vaak dat Nederlands vertaald wordt naar... Nederlands.
Mocht je vreemde afwijkingen zien dan kun je via Git blame zien of het een bewuste keuze van Alex was, die keuzes moeten blijven staan.

@jiromaykin jiromaykin force-pushed the translations/2600-update-translations branch from 9fb53f5 to 2302dec Compare July 18, 2024 12:25
@jiromaykin jiromaykin force-pushed the translations/2600-update-translations branch from 14702c1 to edc27c8 Compare July 18, 2024 12:33
@jiromaykin jiromaykin requested a review from swrichards July 18, 2024 13:34
@jiromaykin jiromaykin merged commit 83188c2 into develop Jul 18, 2024
18 checks passed
@jiromaykin jiromaykin deleted the translations/2600-update-translations branch July 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants