-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 [#2626] Add beheerhandleiding to ReadTheDocs #1309
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1309 +/- ##
===========================================
- Coverage 95.13% 95.12% -0.02%
===========================================
Files 983 990 +7
Lines 35847 35769 -78
===========================================
- Hits 34104 34026 -78
Misses 1743 1743 ☔ View full report in Codecov by Sentry. |
1810ef0
to
7db3478
Compare
354be52
to
3b576fb
Compare
@pi-sigma and @swrichards : I added the beheerdershandleiding as the first thing in the hierarchy index because it's in Dutch. And I've used the numbering of the PDF for the chapters/headings - which is also why 'inleiding' is chapter 1 and 'index' is chapter Zero, since I wanted the title in the main and visible index to be 'beheerhandleiding' instead of 'inleiding'. But feel free to suggest otherwise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on not the most enjoyable of chores!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. One thing I noticed is that the copyright still says "Maykin Media"; should be "Maykin" instead. It's a small change, but perhaps should be done in a separate commit/PR.
8af2f03
to
310d7d4
Compare
5d07bf6
to
1cf2293
Compare
@pi-sigma I've removed the 'media' from our company name in this documentation at least 🙂 |
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2626
(Running Sphinx): After 'make HTML' the
.rst
files, with their embedded images, can be viewed in browser.