Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 [#2626] Add beheerhandleiding to ReadTheDocs #1309

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 15, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2626

(Running Sphinx): After 'make HTML' the .rst files, with their embedded images, can be viewed in browser.

@jiromaykin jiromaykin changed the title [#2626] Added beheerhandleiding and images to ReadTheDocs 📝 [#2626] Added beheerhandleiding and images to ReadTheDocs Jul 15, 2024
@jiromaykin jiromaykin changed the title 📝 [#2626] Added beheerhandleiding and images to ReadTheDocs 📝 [#2626] Add beheerhandleiding to ReadTheDocs Jul 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (c891aba) to head (1cf2293).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1309      +/-   ##
===========================================
- Coverage    95.13%   95.12%   -0.02%     
===========================================
  Files          983      990       +7     
  Lines        35847    35769      -78     
===========================================
- Hits         34104    34026      -78     
  Misses        1743     1743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2626-pdf-to-readthedocs branch 7 times, most recently from 1810ef0 to 7db3478 Compare July 16, 2024 15:14
@jiromaykin jiromaykin marked this pull request as ready for review July 16, 2024 15:14
@jiromaykin jiromaykin force-pushed the feature/2626-pdf-to-readthedocs branch from 354be52 to 3b576fb Compare July 16, 2024 15:34
@jiromaykin
Copy link
Contributor Author

@pi-sigma and @swrichards : I added the beheerdershandleiding as the first thing in the hierarchy index because it's in Dutch. And I've used the numbering of the PDF for the chapters/headings - which is also why 'inleiding' is chapter 1 and 'index' is chapter Zero, since I wanted the title in the main and visible index to be 'beheerhandleiding' instead of 'inleiding'. But feel free to suggest otherwise!

Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on not the most enjoyable of chores!

Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One thing I noticed is that the copyright still says "Maykin Media"; should be "Maykin" instead. It's a small change, but perhaps should be done in a separate commit/PR.

@jiromaykin jiromaykin force-pushed the feature/2626-pdf-to-readthedocs branch from 8af2f03 to 310d7d4 Compare July 18, 2024 11:40
@jiromaykin jiromaykin force-pushed the feature/2626-pdf-to-readthedocs branch from 5d07bf6 to 1cf2293 Compare July 18, 2024 15:18
@jiromaykin
Copy link
Contributor Author

@pi-sigma I've removed the 'media' from our company name in this documentation at least 🙂

@jiromaykin jiromaykin requested a review from swrichards July 18, 2024 15:36
@swrichards swrichards merged commit e4fcb11 into develop Jul 18, 2024
18 checks passed
@swrichards swrichards deleted the feature/2626-pdf-to-readthedocs branch July 18, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants