Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken autoload of django-admin-index fixture #1307

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jul 15, 2024

The django-admin-index fixture requires all contenttypes to be
present before being loaded. Previously, we would only ensure
the contenttypes for our own apps were loaded, but this is not
sufficient, as the fixture frequently makes references to third
party apps. This commit clarifies this behavior and ensures that
all contenttypes are loaded.

The django-admin-index fixture requires all contenttypes to be
present before being loaded. Previously, we would only ensure
the contenttypes for our own apps were loaded, but this is not
sufficient, as the fixture frequently makes references to third
party apps. This commit clarifies this behavior and ensures that
all contenttypes are loaded.
@swrichards swrichards force-pushed the issue/dimpact-105-fix-broken-autoload-django-admin-index-fixture branch from d8aaed0 to 30ce5ed Compare July 15, 2024 09:29
@swrichards swrichards requested a review from pi-sigma July 15, 2024 09:37
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.11%. Comparing base (c891aba) to head (363f0db).

Files Patch % Lines
src/open_inwoner/accounts/apps.py 37.50% 5 Missing ⚠️
...inwoner/accounts/tests/test_admin_index_fixture.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1307      +/-   ##
===========================================
- Coverage    95.13%   95.11%   -0.02%     
===========================================
  Files          983      984       +1     
  Lines        35847    35868      +21     
===========================================
+ Hits         34104    34117      +13     
- Misses        1743     1751       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the issue/dimpact-105-fix-broken-autoload-django-admin-index-fixture branch from cbd9fa7 to 0919d6a Compare July 15, 2024 10:20
@swrichards swrichards marked this pull request as ready for review July 15, 2024 11:55
@swrichards swrichards merged commit 0a5426c into develop Jul 15, 2024
18 checks passed
@swrichards swrichards deleted the issue/dimpact-105-fix-broken-autoload-django-admin-index-fixture branch July 15, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants