Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2124] Siteimprove interval pause #1303

Merged
merged 3 commits into from
Aug 15, 2024
Merged

[#2124] Siteimprove interval pause #1303

merged 3 commits into from
Aug 15, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Jul 11, 2024

When the _sz Array is coming in from SiteImprove, only then should the click events be pushed to that same array.

Done: Commented out Mock (the Mock may have been overwriting the ACTUAL _sz object)

  • Added console logging in the code to monitor _sz interactions.
  • Periodically checking the _sz object by using a 'poller'.

Network Tab in inspector (use incognito window, accept cookies, disable adblockers):

Open Network tab.
Reload the page.
Filter by "sz" or relevant domain.
Click on relevant requests to inspect.

See:
issue: https://taiga.maykinmedia.nl/project/open-inwoner/us/2124
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2622

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (8f22d47) to head (7cc079e).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1303      +/-   ##
===========================================
+ Coverage    95.11%   95.23%   +0.11%     
===========================================
  Files          995      999       +4     
  Lines        36472    37984    +1512     
===========================================
+ Hits         34692    36174    +1482     
- Misses        1780     1810      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch 2 times, most recently from 1829a6d to 4128bf4 Compare July 11, 2024 10:23
@jiromaykin jiromaykin marked this pull request as ready for review July 11, 2024 10:44
@jiromaykin jiromaykin changed the title [#2124] Siteimprove interval pause [#2124] Siteimprove interval pause / fix login Tabs Jul 11, 2024
@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch 2 times, most recently from 31b5592 to d5398f5 Compare July 11, 2024 12:53
@jiromaykin jiromaykin changed the title [#2124] Siteimprove interval pause / fix login Tabs [#2124] Siteimprove interval pause Jul 16, 2024
@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch from e1dcb82 to 39031d5 Compare July 16, 2024 17:52
@alextreme
Copy link
Member

To be checked by me with Jiro on thursday

@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch from cfb3012 to 5b93b5a Compare August 15, 2024 10:54
@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch from 5b93b5a to 0dea599 Compare August 15, 2024 10:57
@alextreme
Copy link
Member

Verified on MijnGroningen production, @pi-sigma please review for including in 1.20.x

@jiromaykin jiromaykin requested a review from pi-sigma August 15, 2024 13:14
@jiromaykin jiromaykin force-pushed the fix/2124-siteimprove branch from b642da5 to 7cc079e Compare August 15, 2024 13:21
@alextreme alextreme merged commit b2aca0a into develop Aug 15, 2024
35 checks passed
@alextreme alextreme deleted the fix/2124-siteimprove branch August 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants