-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2124] Siteimprove interval pause #1303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1303 +/- ##
===========================================
+ Coverage 95.11% 95.23% +0.11%
===========================================
Files 995 999 +4
Lines 36472 37984 +1512
===========================================
+ Hits 34692 36174 +1482
- Misses 1780 1810 +30 ☔ View full report in Codecov by Sentry. |
1829a6d
to
4128bf4
Compare
31b5592
to
d5398f5
Compare
e1dcb82
to
39031d5
Compare
To be checked by me with Jiro on thursday |
cfb3012
to
5b93b5a
Compare
5b93b5a
to
0dea599
Compare
Verified on MijnGroningen production, @pi-sigma please review for including in 1.20.x |
b642da5
to
7cc079e
Compare
pi-sigma
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
_sz
Array is coming in from SiteImprove, only then should the click events be pushed to that same array.Done: Commented out Mock (the Mock may have been overwriting the ACTUAL
_sz
object)_sz
interactions._sz
object by using a 'poller'.Network Tab in inspector (use incognito window, accept cookies, disable adblockers):
Open Network tab.
Reload the page.
Filter by "sz" or relevant domain.
Click on relevant requests to inspect.
See:
issue: https://taiga.maykinmedia.nl/project/open-inwoner/us/2124
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2622