-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2581] Make email notifications optional #1302
Conversation
0420b9e
to
1e8c192
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1302 +/- ##
===========================================
+ Coverage 95.13% 95.14% +0.01%
===========================================
Files 991 993 +2
Lines 35885 35966 +81
===========================================
+ Hits 34139 34220 +81
Misses 1746 1746 ☔ View full report in Codecov by Sentry. |
src/open_inwoner/accounts/tests/test_notify_expiring_actions.py
Outdated
Show resolved
Hide resolved
src/open_inwoner/accounts/tests/test_notify_expiring_actions.py
Outdated
Show resolved
Hide resolved
4597848
to
3a1ff0a
Compare
3a1ff0a
to
0a9891f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly small naming things and a missing a test, nothing major (if you get around to it tomorrow I can probably still do the final review).
src/open_inwoner/accounts/templates/accounts/registration_necessary.html
Outdated
Show resolved
Hide resolved
src/open_inwoner/configurations/tests/bootstrap/test_setup_site_config.py
Outdated
Show resolved
Hide resolved
349f4c5
to
d71953d
Compare
src/open_inwoner/accounts/templates/accounts/registration_necessary.html
Outdated
Show resolved
Hide resolved
…cases - replace cron jobs with celery tasks - explicitly mark internal utility functions for case notifications
d71953d
to
0fbd4ab
Compare
The PR adds options in
SiteConfiguration
to globally enable/disable user notifications for expiring plans, messages etc.Taiga: task #2581
Dependencies: #1289