Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2581] Make email notifications optional #1302

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Jul 10, 2024

The PR adds options in SiteConfiguration to globally enable/disable user notifications for expiring plans, messages etc.

Taiga: task #2581

Dependencies: #1289

@pi-sigma pi-sigma force-pushed the task/2581-optional-notifications branch from 0420b9e to 1e8c192 Compare July 11, 2024 07:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (be71938) to head (f91ff35).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1302      +/-   ##
===========================================
+ Coverage    95.13%   95.14%   +0.01%     
===========================================
  Files          991      993       +2     
  Lines        35885    35966      +81     
===========================================
+ Hits         34139    34220      +81     
  Misses        1746     1746              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review July 12, 2024 10:28
@pi-sigma pi-sigma requested a review from swrichards July 12, 2024 10:28
@pi-sigma pi-sigma force-pushed the task/2581-optional-notifications branch 5 times, most recently from 4597848 to 3a1ff0a Compare July 18, 2024 12:11
@pi-sigma pi-sigma requested a review from swrichards July 18, 2024 12:38
@pi-sigma pi-sigma force-pushed the task/2581-optional-notifications branch from 3a1ff0a to 0a9891f Compare July 18, 2024 12:42
Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly small naming things and a missing a test, nothing major (if you get around to it tomorrow I can probably still do the final review).

@pi-sigma pi-sigma force-pushed the task/2581-optional-notifications branch 2 times, most recently from 349f4c5 to d71953d Compare July 24, 2024 10:27
@pi-sigma pi-sigma requested a review from swrichards July 24, 2024 12:19
…cases

    - replace cron jobs with celery tasks
    - explicitly mark internal utility functions for case notifications
@pi-sigma pi-sigma force-pushed the task/2581-optional-notifications branch from d71953d to 0fbd4ab Compare July 24, 2024 12:36
@pi-sigma pi-sigma requested a review from swrichards July 24, 2024 12:37
@pi-sigma pi-sigma merged commit 6874482 into develop Jul 24, 2024
18 checks passed
@pi-sigma pi-sigma deleted the task/2581-optional-notifications branch July 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants