[#2606] Refactor flakey test, use more general assertions #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the test asserted equality of expected + actual list, which
is not guaranteed (presumably this is due to parallel tests; it
doesn't seem to occur when tests run sequentially)
- what is needed are only the weaker assertions about content
being/not being included in the form options
e31ac97 to
119c653
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1293 +/- ##
===========================================
- Coverage 44.23% 44.22% -0.01%
===========================================
Files 973 973
Lines 35625 35627 +2
===========================================
Hits 15757 15757
- Misses 19868 19870 +2 ☔ View full report in Codecov by Sentry. |
swrichards
approved these changes
Jul 3, 2024
swrichards
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2602