-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐳 Add setup_configuration script #1291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1291 +/- ##
===========================================
- Coverage 44.24% 44.23% -0.02%
===========================================
Files 972 973 +1
Lines 35577 35602 +25
===========================================
+ Hits 15740 15747 +7
- Misses 19837 19855 +18 ☔ View full report in Codecov by Sentry. |
# Run this script from the root of the repository | ||
|
||
#set -e | ||
${SCRIPTPATH}/wait_for_db.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dit gaat niet werken zonder wait_for_db.sh script: https://github.com/open-zaak/open-zaak/blob/main/bin/wait_for_db.sh
Ik ken setup_configuration niet goed genoeg om te weten of/hoe deze script automatisch wordt uitgevoerd, in Open Zaak zie ik het niet terug. Is dit iets wat je in je helm chart doet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallo @alextreme ,
Het wait_for_db.sh script is nu ook toegevoegd.
Het script is door Anne gemaakt en opgeleverd en het is inderdaad makkelijk om deze te hebben om aan te roepen vanuit een init container, zie: https://github.com/open-zaak/open-zaak/blob/9ac277e8ed012521b2c1c709b4f683d45d90a37c/docker-compose.yml#L68 en https://github.com/maykinmedia/charts/blob/51c6860f1943d6cf03e80c69dc71ba41dadbac7e/charts/openzaak/templates/deployment.yaml#L51
Het setup_configuration python commando aanroepen zou ik ook zonder script kunnen doen, wat als grootste voordeel heeft dat ik niet hoef te wachten op releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait_for_db
setup_configuration.sh
script to the docker build, same as openzaak etc, https://github.com/open-zaak/open-zaak/blob/main/bin/setup_configuration.sh