Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2593] Fix missing coverage data in codecov #1290

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jul 2, 2024

Previously our coverage data was imporperly being shipped to codecov on
two accounts:

  1. We were not combining the data files from each run of the test matrix
    (elastic and main)
  2. The main test run was not running with the appropriate --concurrency
    flag and thus it was missing out on coverage data due to not taking
    into account all test processes.

This commit addresses both issues and ensures codecov receives the
full coverage data file (both runs, all parallel processes).

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (abc196e) to head (22a1ad6).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1290       +/-   ##
============================================
+ Coverage    44.23%   95.13%   +50.90%     
============================================
  Files          973      983       +10     
  Lines        35625    35837      +212     
============================================
+ Hits         15757    34094    +18337     
+ Misses       19868     1743    -18125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the issues/2593-incorrect-coverage-reporting branch 29 times, most recently from ab148e3 to 524fa9e Compare July 3, 2024 15:14
@swrichards swrichards force-pushed the issues/2593-incorrect-coverage-reporting branch 2 times, most recently from ed8ae30 to d12074e Compare July 3, 2024 15:25
@swrichards swrichards changed the title [#2593] Ensure all test coverage is properly collated and sent to cod… [#2593] Fix missing coverage data in codecov Jul 3, 2024
@swrichards swrichards force-pushed the issues/2593-incorrect-coverage-reporting branch from d12074e to 217a986 Compare July 3, 2024 15:32
@swrichards swrichards marked this pull request as ready for review July 3, 2024 17:24
@swrichards swrichards requested a review from pi-sigma July 3, 2024 17:25
@swrichards swrichards requested a review from alextreme July 4, 2024 07:05
Previously our coverage data was imporperly being shipped to codecov on
two accounts:

1. We were not combining the data files from each run of the test matrix
   (elastic and main)
2. The main test run was not running with the appropriate --concurrency
   flag and thus it was missing out on coverage data due to not taking
   into account all test processes.

This commit addresses both issues and ensures codecov receives the
full coverage data file (both runs, all parallel processes).
@swrichards swrichards force-pushed the issues/2593-incorrect-coverage-reporting branch from 217a986 to 22a1ad6 Compare July 4, 2024 07:25
@alextreme alextreme merged commit ab1950d into develop Jul 4, 2024
18 checks passed
@alextreme alextreme deleted the issues/2593-incorrect-coverage-reporting branch July 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants