-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2570] Add multi-backend support to ZGW iotypes importer #1284
[#2570] Add multi-backend support to ZGW iotypes importer #1284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1284 +/- ##
===========================================
- Coverage 44.24% 44.23% -0.01%
===========================================
Files 972 973 +1
Lines 35577 35594 +17
===========================================
+ Hits 15740 15746 +6
- Misses 19837 19848 +11 ☔ View full report in Codecov by Sentry. |
72d6a84
to
609b172
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. One small question/suggestion about the messages, though not sure if it's feasible.
AAA - zaaktype-aaa | ||
BBB - zaaktype-bbb | ||
BBB - zaaktype-bbb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we distinguish between these configs as in the case of the catalogi messages above (e.g. by displaying the netloc of the service api root or something else)?. It's quite useful in the catalogus case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point, added the catalogus base url across the objects: see what you think.
609b172
to
0b8692b
Compare
0b8692b
to
a113ac1
Compare
No description provided.