♿ [#2435] Add aria-expanded to mobile anchors navigation #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1273 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 980 980
Lines 35687 35687
========================================
Hits 33969 33969
Misses 1718 1718 ☔ View full report in Codecov by Sentry. |
ca054a5 to
0c3cd06
Compare
012381f to
b9fc781
Compare
pi-sigma
reviewed
Jun 27, 2024
| {% button href="#" icon="expand_more" icon_position="after" extra_classes="anchor-menu--mobile__title anchor-menu__toggle" bordered=False text=_("Op deze pagina") %} | ||
| <ul class="anchor-menu__list"> | ||
| {% button icon="expand_more" icon_position="after" extra_classes="anchor-menu--mobile__title anchor-menu__toggle" bordered=False text=_("Op deze pagina") ariaExpanded="false" ariaControls="anchor-menu-list-mobile" %} | ||
| <ul class="anchor-menu__list" id="anchor-menu-list-mobile"> |
There was a problem hiding this comment.
I don't see where the id is used. Is this necessary?
There was a problem hiding this comment.
Yes. That ID is needed for the WAI_ARIA attribute "aria-controls".
Read more here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-controls
pi-sigma
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue https://taiga.maykinmedia.nl/project/open-inwoner/task/2435
note:
aria-expandedonly works for the elements that indicate if a control is expanded or collapsed.aria-controlsis not a hard requirement, but 'recommended'