[#2564] Mark catalogus as a required field on ZaakTypeconfig

[swrichards]

No description provided.

[pi-sigma]

There are two places that rely on the condition that catalogus is null and should be changed:

• https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/models.py#L389
• https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/managers.py#L101

[pi-sigma]

We have a utility class for migration tests that sets + resets the constraint checks (among other things). You don't have to use it, but take a look: https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/utils/tests/test_migrations.py

[swrichards]

Indeed. the difficulty here is that you need to test a failing migration, which the utility isn't set up for (I set out to address that in #1267).

[pi-sigma]

Ah, hadn't looked at that one, perfect.

[swrichards]

If you're generally happy with #1267 then I can rebase this PR on top of it and use the new-fangled utility to simplify this test.

[swrichards]

Done, usage example of the failing scenario at

open-inwoner/src/open_inwoner/openzaak/tests/test_migrations.py

Lines 78 to 96 in ef78f3c

	class TestMakeZaakTypeConfigCatalogusRequired(TestFailingMigrations):
	migrate_from = "0051_drop_root_zgw_fields"
	migrate_to = "0052_zaaktypeconfig_catalogus_is_required"
	app = "openzaak"
	def setUpBeforeMigration(self, apps):
	ZaakTypeConfig = apps.get_model("openzaak", "ZaakTypeConfig")
	ZaakTypeConfig.objects.create(urls=[], catalogus=None, identificatie="foobar")
	def test_migration_0051_to_0052_raises_with_descriptive_exception_message(self):
	with self.assertRaises(DataError) as cm:
	self.attempt_migration()
	self.assertEqual(
	str(cm.exception),
	"Your database contains 1 ZaakTypeConfig row(s) with a missing `catalogus` field."
	" This field is now required: please manually update all the affected rows or re-sync"
	" your ZGW objects to ensure the field is included.",
	)

[swrichards]

There are two places that rely on the condition that catalogus is null and should be changed:

* https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/models.py#L389

* https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openzaak/managers.py#L101

Excellent catch, thanks, will address these.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (2149012) to head (098ed8b).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1262      +/-   ##
===========================================
- Coverage    95.18%   95.17%   -0.01%     
===========================================
  Files          980      981       +1     
  Lines        35687    35665      -22     
===========================================
- Hits         33969    33945      -24     
- Misses        1718     1720       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.