♿ [#2340] Header/footer logo use alt from image configuration #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
commented
Jun 17, 2024
| @@ -55,7 +55,7 @@ def settings(request): | |||
| }, | |||
| "footer": { | |||
| "logo": config.footer_logo, | |||
| "logo_alt": config.name, | |||
| "logo_alt": config.logo.default_alt_text, | |||
There was a problem hiding this comment.
@pi-sigma Not sure I am using the correct approach here... Not quite sure why this value is set differently for the footer anyway
(would this just be for emailtemplates?)
pi-sigma
requested changes
Jun 18, 2024
a7385b2 to
f2ce234
Compare
pi-sigma
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2340
Both the header logo and the footer logo need to use the same ALT that can be set in the Admin in the 'mappen' configuration: http://localhost:8000/admin/filer/folder/
Each image in there (navigate to any in the mappen/directories) has an 'ALT' field that can be set - but when empty the image should just receive value from the Site Name.