Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2352] Remove faulty aria-label and add external link #1257

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

jiromaykin
Copy link
Contributor

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2343

This approach ensures that screen readers can read both the visible link text (inside the a-href anchor) and the additional information about the link opening a new/different website, which is information coming from the meaningful icon.

@jiromaykin jiromaykin added the Accessibility Improving accessibility label Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (6157084) to head (3c5a94d).
Report is 16 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/utils/ckeditor.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1257      +/-   ##
===========================================
- Coverage    95.22%   95.19%   -0.04%     
===========================================
  Files          974      978       +4     
  Lines        35471    35607     +136     
===========================================
+ Hits         33778    33896     +118     
- Misses        1693     1711      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin requested review from alextreme June 13, 2024 15:19
@alextreme
Copy link
Member

Assigning to Paul for review next week, requires a double-check

@jiromaykin jiromaykin marked this pull request as ready for review June 17, 2024 07:48
@jiromaykin jiromaykin requested a review from pi-sigma June 17, 2024 08:20
@jiromaykin jiromaykin requested a review from pi-sigma June 17, 2024 14:23
@alextreme alextreme merged commit d03d3a2 into develop Jun 17, 2024
16 checks passed
@alextreme alextreme deleted the issue/2343-A11y-1.1.1-external-link-text branch June 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants