Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2369] Add focus-style for custom file-input #1255

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

jiromaykin
Copy link
Contributor

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2369

Will look a bit different in various browsers:

outline

@jiromaykin jiromaykin force-pushed the issue/2369-A11y-2.4.7-focus-upload-labels branch from bb97167 to 4c4074c Compare June 13, 2024 10:12
@jiromaykin jiromaykin marked this pull request as ready for review June 13, 2024 10:13
@jiromaykin jiromaykin added the Accessibility Improving accessibility label Jun 13, 2024
@jiromaykin jiromaykin requested a review from alextreme June 13, 2024 10:25
@jiromaykin jiromaykin changed the title [#2369] Add focus-style for custom file-input ♿ [#2369] Add focus-style for custom file-input Jun 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (6157084) to head (4c4074c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1255   +/-   ##
========================================
  Coverage    95.22%   95.22%           
========================================
  Files          974      974           
  Lines        35471    35471           
========================================
  Hits         33778    33778           
  Misses        1693     1693           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit wat mij betreft. Zolang deze focus-style niet standaard wordt getoond...

@alextreme alextreme merged commit 8058110 into develop Jun 14, 2024
16 checks passed
@alextreme alextreme deleted the issue/2369-A11y-2.4.7-focus-upload-labels branch June 14, 2024 08:18
@jiromaykin
Copy link
Contributor Author

Ziet er goed uit wat mij betreft. Zolang deze focus-style niet standaard wordt getoond...

Welke situaties bedoel je hier met 'standaard'? Eigenijk zou dit juist overal moeten worden doorgevoerd, wanneer er keyboard focus is, voor consistentie - maar dan zou Dimpact/de designer ook mee moeten kijken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Improving accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants