-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿ [#2376] Add aria-expanded for desktop navigation menus #1246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1246 +/- ##
========================================
Coverage 95.20% 95.20%
========================================
Files 978 978
Lines 35603 35603
========================================
Hits 33896 33896
Misses 1707 1707 ☔ View full report in Codecov by Sentry. |
892da9b
to
dd1b3c7
Compare
39d393e
to
6b08ca2
Compare
7eb41ea
to
57d29d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we only need this for the "Onderwerpen" button? The "Welkom" button currently doesn't have an aria-expanded
attribute
? But it does. And yes, they both need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, was looking in the wrong place for the "Welkom" button. Works fine (though only tested on FireFox and Chrome).
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2376
aria-expanded should be added to the element that controls the expanded state of other elements.
Due to Apple's conscious decision in 2008 to not set focus on clicked buttons, this still behaves slightly different in Safari (opening 1 menu does not close the other there).