♿ [#2370] Enable equal text-alternative for Header and Footer logo #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
685d434 to
086d338
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1245 +/- ##
========================================
Coverage 95.22% 95.22%
========================================
Files 974 974
Lines 35471 35471
========================================
Hits 33778 33778
Misses 1693 1693 ☔ View full report in Codecov by Sentry. |
alextreme
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2370
de tekstuele inhoud van de Alt/Aria/Title tekstalternatieven is een taak voor redacteuren maar de hardcoded 'homepage' tekst in het Header logo moet worden verwijderd zodat het tekstalternatief volledig door de redacteur kan worden bepaald.
En: het tekstalternatief moet ook eigenlijk starten met de labeltekst, dus dan zou Homepage pas op het eind gezet mogen worden, maar het kan hier beter verwijderd worden,
(i.p.v. Homepage wil men bijvoorbeeld misschien "inlogpagina" gebruiken).