-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2504] Adding architecture documentation #1244
[#2504] Adding architecture documentation #1244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added https://taiga.maykinmedia.nl/project/open-inwoner/task/2543 for this, we don't have a logo atm and the one currently used is originally from i4Sociaal |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1244 +/- ##
===========================================
- Coverage 95.22% 95.20% -0.03%
===========================================
Files 974 978 +4
Lines 35471 35603 +132
===========================================
+ Hits 33778 33896 +118
- Misses 1693 1707 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just minor copy-editing, feel free to cherry-pick at will.
03d4ebd
to
bf6e662
Compare
Thanks Sidney for the tweaks: merged in the suggestions, added the updated logo and rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links don't work (see comment). Let me know if you don't have this issue.
4f8795d
to
88d70ce
Compare
No description provided.