Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2504] Adding architecture documentation #1244

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

alextreme
Copy link
Member

No description provided.

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could approve but just wondering: Should these docs use the Dimpact logo?
open-Formulieren has its own logo in their docs:
⬇️

Screenshot 2024-06-10 at 12 36 09

@alextreme
Copy link
Member Author

I could approve but just wondering: Should these docs use the Dimpact logo?
open-Formulieren has its own logo in their docs:

Added https://taiga.maykinmedia.nl/project/open-inwoner/task/2543 for this, we don't have a logo atm and the one currently used is originally from i4Sociaal

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (7516e19) to head (88d70ce).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1244      +/-   ##
===========================================
- Coverage    95.22%   95.20%   -0.03%     
===========================================
  Files          974      978       +4     
  Lines        35471    35603     +132     
===========================================
+ Hits         33778    33896     +118     
- Misses        1693     1707      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just minor copy-editing, feel free to cherry-pick at will.

@alextreme alextreme force-pushed the issue/task-2504-architecture-documentation branch from 03d4ebd to bf6e662 Compare June 14, 2024 13:01
@alextreme
Copy link
Member Author

Thanks Sidney for the tweaks: merged in the suggestions, added the updated logo and rebased

Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links don't work (see comment). Let me know if you don't have this issue.

@alextreme alextreme requested a review from pi-sigma June 17, 2024 12:18
@alextreme alextreme force-pushed the issue/task-2504-architecture-documentation branch from 4f8795d to 88d70ce Compare June 17, 2024 12:50
@alextreme alextreme merged commit 61fdb4a into develop Jun 17, 2024
16 checks passed
@alextreme alextreme deleted the issue/task-2504-architecture-documentation branch June 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants