Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2416] Scope ZGW clients cache keys by the underlying service endpoint #1237

Merged
merged 1 commit into from
Jun 5, 2024
Merged

[#2416] Scope ZGW clients cache keys by the underlying service endpoint #1237

merged 1 commit into from
Jun 5, 2024

Conversation

swrichards
Copy link
Collaborator

@swrichards swrichards commented Jun 3, 2024 •
edited
Loading

Taiga #2516.

@swrichards swrichards changed the title Scope ZGW clients cache keys by the underlying service endpoint [#2424] Scope ZGW clients cache keys by the underlying service endpoint Jun 3, 2024
@swrichards swrichards changed the title [#2424] Scope ZGW clients cache keys by the underlying service endpoint [#2416] Scope ZGW clients cache keys by the underlying service endpoint Jun 3, 2024
@swrichards swrichards force-pushed the tasks/2516-zgw-caching-scoped-by-endpoint branch from 4fd27d1 to f60be85 Compare June 4, 2024 18:09
@swrichards swrichards marked this pull request as ready for review June 4, 2024 19:08
@swrichards swrichards requested a review from alextreme June 4, 2024 20:04
@swrichards swrichards force-pushed the tasks/2516-zgw-caching-scoped-by-endpoint branch from f60be85 to 54f2d72 Compare June 5, 2024 09:24
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (efe3de2) to head (54f2d72).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1237   +/-   ##
========================================
  Coverage    95.22%   95.22%           
========================================
  Files          971      971           
  Lines        35414    35414           
========================================
  Hits         33723    33723           
  Misses        1691     1691

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alextreme
alextreme approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was first a bit in doubt if I'd prefer 'key:url' or 'url:key' but as the proposed order goes from general-to-specific this feels like the way to go

@alextreme alextreme merged commit 23a6061 into develop Jun 5, 2024
16 checks passed
@alextreme alextreme deleted the tasks/2516-zgw-caching-scoped-by-endpoint branch June 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextreme alextreme alextreme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swrichards @codecov-commenter @alextreme