Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2507] Fixed and added test for 'django-admin-index' fixture #1220

Merged
merged 1 commit into from
May 28, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented May 27, 2024

I think the mechanism wasn't broken, it just errored on bad data (there was a content-type in there that was removed).

Note it listens to the post-migrate signal (eg: not application startup). If we runt this on application start it would run for every test and management command as well (and it deletes and re-creates all the records)

Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/us/2482

@Bartvaderkin Bartvaderkin requested a review from pi-sigma May 27, 2024 14:21
@Bartvaderkin Bartvaderkin marked this pull request as ready for review May 27, 2024 14:21
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.20%. Comparing base (9347350) to head (0b8e598).

Files Patch % Lines
src/open_inwoner/accounts/apps.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1220      +/-   ##
===========================================
- Coverage    95.21%   95.20%   -0.01%     
===========================================
  Files          968      968              
  Lines        35256    35261       +5     
===========================================
+ Hits         33568    33571       +3     
- Misses        1688     1690       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin force-pushed the fix/2507-fix-admin-index-script branch from 27bf243 to 58c3229 Compare May 28, 2024 07:55
@Bartvaderkin Bartvaderkin force-pushed the fix/2507-fix-admin-index-script branch from 58c3229 to 0b8e598 Compare May 28, 2024 08:06
@Bartvaderkin
Copy link
Contributor Author

@pi-sigma In hindsight I don't think the issue was the signal, just the bad data, and running this on application startup is not actually desirable.

Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@alextreme alextreme merged commit e952ad5 into develop May 28, 2024
16 checks passed
@alextreme alextreme deleted the fix/2507-fix-admin-index-script branch May 28, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants