[#2327+#2355] Send verification e-mail immedately #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pi-sigma please adress the 2 failing tests in open_inwoner.mail.tests.test_verification.TestMailVerificationMiddlewareFlow. The way how I did it may not be a good idea and require discussion with @Bartvaderkin. If that's the case wait until after the current sprint to tackle this |
- when the user is redirected to the email verification page, we check
the request session if an email has been sent already
|
Tests are fixed. I added @Bartvaderkin as a reviewer to check if we want to roll with this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1210 +/- ##
========================================
Coverage 95.21% 95.21%
========================================
Files 959 959
Lines 34650 34655 +5
========================================
+ Hits 32993 32998 +5
Misses 1657 1657 ☔ View full report in Codecov by Sentry. |
Bartvaderkin
approved these changes
May 16, 2024
pi-sigma
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.