Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2461] Add setup configuration steps for CMS #1208

Merged
merged 1 commit into from
May 27, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented May 14, 2024

Taiga: #2461

Depends on maykinmedia/django-setup-configuration#9, which needs to be merged first.

@pi-sigma pi-sigma force-pushed the task/2461-setup-config-cms branch 4 times, most recently from e35a997 to 4e7f0e0 Compare May 16, 2024 10:25
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 99.62264% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.25%. Comparing base (dec9dc8) to head (882cc97).
Report is 5 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/configurations/bootstrap/cms.py 98.48% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
+ Coverage    95.21%   95.25%   +0.03%     
===========================================
  Files          961      963       +2     
  Lines        34804    35069     +265     
===========================================
+ Hits         33139    33404     +265     
  Misses        1665     1665              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2461-setup-config-cms branch 3 times, most recently from a76ee85 to 882cc97 Compare May 23, 2024 12:19
@pi-sigma pi-sigma marked this pull request as ready for review May 23, 2024 13:03
@pi-sigma pi-sigma requested a review from Bartvaderkin May 23, 2024 13:04
Comment on lines +76 to +78
def __init__(self):
self.app_name = "ssd"
self.app_hook = SSDApphook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can set these as class level attributes like the other values (eg: not per instance in the constructor).

@alextreme alextreme merged commit 7911b8c into develop May 27, 2024
15 checks passed
@alextreme alextreme deleted the task/2461-setup-config-cms branch May 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants