Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2460] Refactor KVK branch view #1204

Merged
merged 1 commit into from
May 16, 2024
Merged

[#2460] Refactor KVK branch view #1204

merged 1 commit into from
May 16, 2024

Conversation

pi-sigma
Copy link
Contributor

  • Save company_branches on form instance instead of retrieving it through get_context_data to avoid multiple IO calls
  • Move custom validation of branch number out of the POST of the form view and into the form itself

Taiga: #2460

@pi-sigma pi-sigma force-pushed the refactor/kvk-branch-view branch from 48163f6 to 82d6b93 Compare May 11, 2024 15:23
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.22%. Comparing base (44b46e5) to head (9af27d9).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1204   +/-   ##
========================================
  Coverage    95.21%   95.22%           
========================================
  Files          959      959           
  Lines        34650    34652    +2     
========================================
+ Hits         32993    32996    +3     
+ Misses        1657     1656    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review May 13, 2024 07:17
@pi-sigma pi-sigma requested a review from Bartvaderkin May 13, 2024 07:18
Bartvaderkin
Bartvaderkin approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be cool to have more functionality into the form .save() but this is already a big improvement.

@pi-sigma pi-sigma marked this pull request as draft May 16, 2024 09:41
@pi-sigma
[#2460] Refactor KVK branch view
9af27d9 
    - save company_branches on form instance instead of retrieving it
      through get_context_data to avoid multiple IO calls
    - move custom validation of branch number out of the POST of the
      form view and into the form itself
@pi-sigma pi-sigma force-pushed the refactor/kvk-branch-view branch from 82d6b93 to 9af27d9 Compare May 16, 2024 09:41
@pi-sigma pi-sigma marked this pull request as ready for review May 16, 2024 09:42
@alextreme alextreme merged commit dec9dc8 into develop May 16, 2024
15 checks passed
@alextreme alextreme deleted the refactor/kvk-branch-view branch May 16, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pi-sigma @codecov-commenter @Bartvaderkin @alextreme