Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2454] Add IPv6Address to JSONEncoderMixin #1202

Merged
merged 1 commit into from
May 13, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented May 8, 2024

Support for encoding IPv6 addresses was missing from the JSONEncoderMixin used for creating subscriptions

Taiga: #2454

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (c54f8e1) to head (192b482).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1202   +/-   ##
========================================
  Coverage    95.20%   95.20%           
========================================
  Files          958      959    +1     
  Lines        34608    34620   +12     
========================================
+ Hits         32949    32961   +12     
  Misses        1659     1659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review May 8, 2024 12:31
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems fine but is is unclear if they support IPv6, let's assume they do.

@alextreme
Copy link
Member

We'll know soon enough...

@alextreme alextreme merged commit e7f2d14 into develop May 13, 2024
15 checks passed
@alextreme alextreme deleted the issue/2454-laposta-type-error branch May 13, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants