Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2424] Automatically check that config docs have been created/updated #1192

Closed
wants to merge 10 commits into from

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented May 1, 2024

  • Create management command to check that config docs have been created/updated
  • Update CI with command

Depends on #1150, which needs to be merged first

Taiga: #2242

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 94.31818% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 95.17%. Comparing base (475ae94) to head (78e79b1).

Files Patch % Lines
src/open_inwoner/configurations/bootstrap/base.py 88.88% 9 Missing ⚠️
src/open_inwoner/conf/app/setup_configuration.py 88.67% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1192      +/-   ##
===========================================
- Coverage    95.18%   95.17%   -0.01%     
===========================================
  Files          956      958       +2     
  Lines        34603    34747     +144     
===========================================
+ Hits         32937    33072     +135     
- Misses        1666     1675       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the task/2424-check-config-docs branch 3 times, most recently from e4a0fe9 to 1e60ec8 Compare May 1, 2024 09:43
@pi-sigma pi-sigma force-pushed the task/2424-check-config-docs branch from 1e60ec8 to 78e79b1 Compare May 1, 2024 09:51
@pi-sigma pi-sigma closed this May 23, 2024
@pi-sigma
Copy link
Contributor Author

Implemented via maykinmedia/django-setup-configuration#9, so this is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants