Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2404] Avoid redirect cycle for DigiD login with email required #1182

Merged
merged 3 commits into from
May 10, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Apr 26, 2024

A redirect cycle occurs for DigiD login when email verification is required

Taiga: #2404

@pi-sigma pi-sigma requested a review from stevenbal April 26, 2024 15:02
@pi-sigma pi-sigma force-pushed the fix/2404-redirect-cycle branch from a2335d8 to 9f1e84a Compare April 26, 2024 15:35
@alextreme alextreme requested a review from Bartvaderkin April 26, 2024 16:24
@pi-sigma pi-sigma force-pushed the fix/2404-redirect-cycle branch from 9f1e84a to f6a0e11 Compare April 26, 2024 16:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (1e0422a) to head (e976069).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1182      +/-   ##
===========================================
+ Coverage    95.16%   95.18%   +0.02%     
===========================================
  Files          955      956       +1     
  Lines        34564    34605      +41     
===========================================
+ Hits         32893    32939      +46     
+ Misses        1671     1666       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the fix/2404-redirect-cycle branch from f6a0e11 to e976069 Compare April 26, 2024 17:48
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add these to the list in get_always_pass_prefixes() above instead of hard coding them in the base class.

@pi-sigma
Copy link
Contributor Author

Please just add these to the list in get_always_pass_prefixes() above instead of hard coding them in the base class.

Doesn't work because the cms profile app might not be active, which results in failing tests (no match for reverse(profile:...)).

@pi-sigma pi-sigma marked this pull request as ready for review April 29, 2024 07:51
@pi-sigma pi-sigma requested a review from Bartvaderkin April 29, 2024 07:53
@pi-sigma pi-sigma force-pushed the fix/2404-redirect-cycle branch from 7e37f33 to eeb02ca Compare May 7, 2024 09:32
@pi-sigma pi-sigma requested a review from stevenbal May 7, 2024 10:14
@alextreme alextreme merged commit 9de9afb into develop May 10, 2024
15 checks passed
@alextreme alextreme deleted the fix/2404-redirect-cycle branch May 10, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants