-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2404] Avoid redirect cycle for DigiD login with email required #1182
Conversation
a2335d8
to
9f1e84a
Compare
9f1e84a
to
f6a0e11
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1182 +/- ##
===========================================
+ Coverage 95.16% 95.18% +0.02%
===========================================
Files 955 956 +1
Lines 34564 34605 +41
===========================================
+ Hits 32893 32939 +46
+ Misses 1671 1666 -5 ☔ View full report in Codecov by Sentry. |
f6a0e11
to
e976069
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please just add these to the list in get_always_pass_prefixes()
above instead of hard coding them in the base class.
Doesn't work because the cms profile app might not be active, which results in failing tests (no match for |
7e37f33
to
eeb02ca
Compare
A redirect cycle occurs for DigiD login when email verification is required
Taiga: #2404