Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ [#2373] Make aria-labels same as (hidden) texts #1181

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Apr 25, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2373

A small change with big effects.
aria-labels only work on interactive elements and need to at least 'contain' keywords that are inside the visible or invisible text of the component.

Side note: title attributes are not meant for accessibility, and should actually contain different, more meaningful text than the readable text of an interactive element. But this has not been addressed as an issue anywhere in the report - so we're only changing the aria-label here, as per request.

TL;DR: I changed the order of {% firstof title text %}

@jiromaykin jiromaykin marked this pull request as ready for review April 25, 2024 14:01
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

We'll have to see how accurate these title vs text arguments have been set throughout the project but that would be that other task.

Maybe we should also make this choices more of a thing because I'm not so up-2-date on those rules, and it is likely we don't pass enough info into some contexts.

@alextreme alextreme merged commit 9b6e22f into develop Apr 26, 2024
15 checks passed
@alextreme alextreme deleted the issue/2373-a11y-scroll-label branch April 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants