♿ [#2373] Make aria-labels same as (hidden) texts #1181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2373
A small change with big effects.
aria-labels only work on interactive elements and need to at least 'contain' keywords that are inside the visible or invisible text of the component.
Side note: title attributes are not meant for accessibility, and should actually contain different, more meaningful text than the readable text of an interactive element. But this has not been addressed as an issue anywhere in the report - so we're only changing the aria-label here, as per request.
TL;DR: I changed the order of
{% firstof title text %}