-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2328] Refactor tabpanels on login page #1169
Conversation
3a0099b
to
693949a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1169 +/- ##
========================================
Coverage 95.13% 95.13%
========================================
Files 957 957
Lines 34645 34645
========================================
Hits 32960 32960
Misses 1685 1685 ☔ View full report in Codecov by Sentry. |
const zakelijkHeader = document.getElementById('zakelijk_tab') | ||
const particulierHeader = document.getElementById('particulier_tab') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In de if heb je dit:
const zakelijkTab = document.getElementById('zakelijk_tab')
const particulierTab = document.getElementById('particulier_tab')
Maar in de else heten ze anders :|
const zakelijkHeader = document.getElementById('zakelijk_tab')
const particulierHeader = document.getElementById('particulier_tab')
Je kan die twee regels ook gewoon boven de if zetten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ik was tegelijkertijd teveel dingen aan het hernoemen waardoor Find-and-replace niet vlekkeloos ging :-D bij deze gecorrigeerd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Met comment voor codestyle.
issue here: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2328
refactor from feedback on #992