Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2328] Refactor tabpanels on login page #1169

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin force-pushed the fix/2328-login-refactor branch from 3a0099b to 693949a Compare April 22, 2024 10:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (aa07970) to head (e6ec0d7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1169   +/-   ##
========================================
  Coverage    95.13%   95.13%           
========================================
  Files          957      957           
  Lines        34645    34645           
========================================
  Hits         32960    32960           
  Misses        1685     1685           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin marked this pull request as ready for review April 22, 2024 11:39
@jiromaykin jiromaykin requested a review from Bartvaderkin April 22, 2024 11:39
@jiromaykin jiromaykin changed the title [#2328] Refactored tabpanels on login page [#2328] Refactor tabpanels on login page Apr 22, 2024
Comment on lines 68 to 69
const zakelijkHeader = document.getElementById('zakelijk_tab')
const particulierHeader = document.getElementById('particulier_tab')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In de if heb je dit:

const zakelijkTab = document.getElementById('zakelijk_tab')
const particulierTab = document.getElementById('particulier_tab')

Maar in de else heten ze anders :|

  const zakelijkHeader = document.getElementById('zakelijk_tab')
  const particulierHeader = document.getElementById('particulier_tab')

Je kan die twee regels ook gewoon boven de if zetten.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ik was tegelijkertijd teveel dingen aan het hernoemen waardoor Find-and-replace niet vlekkeloos ging :-D bij deze gecorrigeerd.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Met comment voor codestyle.

@alextreme alextreme merged commit cecdb72 into develop Apr 24, 2024
15 checks passed
@alextreme alextreme deleted the fix/2328-login-refactor branch April 24, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants