♻️ [#2257] Fetch subscriptions for user directly from Laposta

[stevenbal]

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2257

Notes:

• Unfortunately it is not possible to retrieve all subscriptions for a given email adress in a single API call, so we have to perform an API call for each list
• The API applies throttling based on the used API key, limiting to 30 calls per minute (or 120 if it's a paid account), so I decided to apply some caching to not let the number of request too out of hand

[alextreme]

@Bartvaderkin to review, after approval can be merged

[Bartvaderkin]

Having to retrieve everything is not ideal because there could be thousands of subscribers. Are we sure about the url encoding (quote plus etc)? It'd be weird if they can't handle name+dummy@gmail.com that people use all the time.

[stevenbal]

I tried it both with and without quoting the email:

alex+111111110@maykinmedia.nl and foo@bar.org are subscribed to the list:

I can directly fetch the relation for foo@bar.org:

But I cannot do that for the email with a plus:

[Bartvaderkin]

Good tests, but it feels like something is wrong that we need to download the while subscriber database to look at a single user's subscriptions.

[stevenbal]

I'll email Laposta to ask if they know about this issue, but in the meantime I'm not sure if there is another (easier) way to fix this

[Bartvaderkin]

Ok cool, will be interesting. If it takes too long or they don't have anything we can use this solution and see.

[alextreme]

But... this is mentioned in their API docs:

[stevenbal]

oh well, I'll do that instead then

[stevenbal]

Removed the workaround and replaced it with double quoting in 504b250

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 98.52941% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (develop@6d6d519). Click here to learn what that means.
Report is 6 commits behind head on develop.

Files	Patch %	Lines
src/open_inwoner/laposta/client.py	95.23%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             develop    #1138   +/-   ##
==========================================
  Coverage           ?   95.05%           
==========================================
  Files              ?      941           
  Lines              ?    33156           
  Branches           ?        0           
==========================================
  Hits               ?    31518           
  Misses             ?     1638           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Bartvaderkin]

Good tests, but it feels like something is wrong that we need to download the while subscriber database to look at a single user's subscriptions.

[Bartvaderkin]

Noting I need to update this with the verified_email