Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2170] Fixed issue with profile_page_is_published() & get_active_app_names() CMS helpers #1125

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Mar 28, 2024

Also added tests for page_display helpers

The problem was Page.application_namespace is not always the clean 'app_name' but gets postfixed with -app-config if the app-hook has an app-config. I fixed it by relying on the other field but it needs a little processing.

…_names() CMS helpers

Also added tests for page_display helpers
@Bartvaderkin Bartvaderkin marked this pull request as ready for review March 28, 2024 15:46
@Bartvaderkin Bartvaderkin requested a review from pi-sigma March 28, 2024 15:46
@Bartvaderkin Bartvaderkin force-pushed the fix/2170-cms-page-publish-helpers branch from c8312f8 to da25f09 Compare March 29, 2024 08:00
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.24561% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (4341c59) to head (da25f09).

Files Patch % Lines
src/open_inwoner/cms/utils/page_display.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1125   +/-   ##
========================================
  Coverage    95.05%   95.05%           
========================================
  Files          923      924    +1     
  Lines        32364    32401   +37     
========================================
+ Hits         30763    30799   +36     
- Misses        1601     1602    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin requested a review from stevenbal March 29, 2024 08:44
@Bartvaderkin Bartvaderkin merged commit f888c74 into develop Mar 29, 2024
15 checks passed
@Bartvaderkin Bartvaderkin deleted the fix/2170-cms-page-publish-helpers branch March 29, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants