-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2221] Fix klant creation with e-suite #1123
Conversation
cb0e4ab
to
d20c3b6
Compare
135fb04
to
eac70a1
Compare
eac70a1
to
031efca
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1123 +/- ##
===========================================
- Coverage 95.06% 95.05% -0.02%
===========================================
Files 931 933 +2
Lines 32947 33009 +62
===========================================
+ Hits 31322 31377 +55
- Misses 1625 1632 +7 ☔ View full report in Codecov by Sentry. |
031efca
to
9e8cb01
Compare
By default, |
9e8cb01
to
e5cb565
Compare
src/open_inwoner/utils/test.py
Outdated
def uuid_from_url(url: str) -> str: | ||
return url.split("/")[-1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could ideally do some checks to see if the bit looks like a UUID.
* replace API specs for OpenKlant prototype with e-suite version
e5cb565
to
ad02be9
Compare
Tested it just now, works both for BSN and KVK 👍 |
Taiga: #2221