Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2221] Fix klant creation with e-suite #1123

Merged
merged 5 commits into from
Apr 8, 2024
Merged

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Mar 28, 2024

  • Make sure Klant is created via e-suite on user login
  • Replace API specs with e-suite compatible versions
  • Change default on OpenZaak and OpenKlant config to not use RSIN
  • Refactor tests + mocks

Taiga: #2221

@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch 2 times, most recently from cb0e4ab to d20c3b6 Compare March 29, 2024 13:51
@pi-sigma pi-sigma marked this pull request as ready for review March 29, 2024 15:10
@pi-sigma pi-sigma changed the title Fix klant creation with e-suite [#2221] Fix klant creation with e-suite Apr 2, 2024
@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch 2 times, most recently from 135fb04 to eac70a1 Compare April 2, 2024 12:26
@pi-sigma pi-sigma marked this pull request as draft April 2, 2024 12:26
@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch from eac70a1 to 031efca Compare April 2, 2024 13:06
@pi-sigma pi-sigma marked this pull request as ready for review April 2, 2024 13:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (2e8d47f) to head (e5cb565).

Files Patch % Lines
src/open_inwoner/openklant/clients.py 75.86% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1123      +/-   ##
===========================================
- Coverage    95.06%   95.05%   -0.02%     
===========================================
  Files          931      933       +2     
  Lines        32947    33009      +62     
===========================================
+ Hits         31322    31377      +55     
- Misses        1625     1632       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch from 031efca to 9e8cb01 Compare April 3, 2024 09:21
@pi-sigma
Copy link
Contributor Author

pi-sigma commented Apr 3, 2024

By default, requests_mock forces query params to be lower case (see https://requests-mock.readthedocs.io/en/latest/knownissues.html). I thought it would be good to change that, since whether or not query params are considered case sensitive is not settled by RFC; it seems to depend on the application. We have other tests (CaseListViewTests) that could also be updated.

@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch from 9e8cb01 to e5cb565 Compare April 3, 2024 10:50
Comment on lines 89 to 90
def uuid_from_url(url: str) -> str:
return url.split("/")[-1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could ideally do some checks to see if the bit looks like a UUID.

@pi-sigma pi-sigma marked this pull request as draft April 4, 2024 09:23
@pi-sigma pi-sigma force-pushed the fix/2221-klant-creation branch from e5cb565 to ad02be9 Compare April 4, 2024 09:27
@pi-sigma pi-sigma marked this pull request as ready for review April 8, 2024 09:10
@stevenbal
Copy link
Contributor

Tested it just now, works both for BSN and KVK 👍

@stevenbal stevenbal merged commit b4ab120 into develop Apr 8, 2024
15 checks passed
@stevenbal stevenbal deleted the fix/2221-klant-creation branch April 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants