🏷️ [#1718] Update typehints to use PEP585 generics #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
suggested changes
Mar 18, 2024
|
|
||
|
|
||
| @dataclass | ||
| class ZaakInformatieObject(ZGWModel): | ||
| url: str | ||
| informatieobject: Union[str, "InformatieObject"] | ||
| zaak: Union[str, Zaak] | ||
| informatieobject: "str | InformatieObject" |
There was a problem hiding this comment.
The union syntax doesn't work with string operands (yet?): python/cpython#90015 (comment).
I'll revert the changes in this file though, because replacing Union and Optional seems to cause issues with zgw_consumers.factory
There was a problem hiding this comment.
The Union/forward reference thing is pretty disappointing. I expected the operator version to be just syntax sugar on Union but apparently not.
| header: Optional[ | ||
| "JaarOpgaveClientPortTypeSendJaarOpgaveClientInput.Header" | ||
| ] = field( | ||
| header: "JaarOpgaveClientPortTypeSendJaarOpgaveClientInput.Header | None" = field( |
3a9dbb4 to
3ed3432
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1094 +/- ##
===========================================
- Coverage 95.03% 95.02% -0.01%
===========================================
Files 911 911
Lines 32038 31991 -47
===========================================
- Hits 30446 30399 -47
Misses 1592 1592 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Mar 18, 2024
Bartvaderkin
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/1718