-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2169] Improve mail-template styling #1072
Conversation
e14aee4
to
e3e5e50
Compare
e3e5e50
to
9e64595
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1072 +/- ##
========================================
Coverage 95.00% 95.00%
========================================
Files 894 894
Lines 31404 31405 +1
========================================
+ Hits 29834 29835 +1
Misses 1570 1570 ☔ View full report in Codecov by Sentry. |
3e09fff
to
0b843cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template language should be consistent
@@ -17,5 +17,5 @@ | |||
</table> | |||
|
|||
<p><a href="{{ plan_list_link }}">Go to your plans</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the text be Dutch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, but this PR for #2169 is really only about styling and about the 3 case_status templates; I'd rather change all the 'other templates properly in task #2120 - I just wanted to do a small correction for the paragraphs here.
ce745ac
to
3e80445
Compare
Mag gemerged worden na verhelpen conflict |
3e80445
to
ced91f7
Compare
detailed issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2169
overall issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2134
These mostly concern
case_document_notification
,case_status_notification_action_required
andcase_status_notification
.ToDo
EXTRA