Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2169] Improve mail-template styling #1072

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Mar 4, 2024

detailed issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2169

overall issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2134

These mostly concern case_document_notification , case_status_notification_action_required and case_status_notification.

ToDo

  • - add a little bit more placeholder-data so CKeditor preview/Testmails look nicer
  • - Spacing between 'met vriendelijke groet…' and 'dit bericht is automatisch…' 2X
  • - faulty whitespace in white rounded-border area
  • - add sharper/higher rez icons
  • - check if there is extra whitespace in the empty columns (making the wrapping Table responsive, max width 600px)
  • - correct the blue info hex color
  • - Spacing 'login' + "U hoeft niets te doen" needs to be larger (info notificatie)  
  • - "Log in" should not be underlined (info notificatie)
  • - Cell-widths tablecells for phonenumber and contactlink should be reversed (2X)

EXTRA

  • align-right for 1 right-column + align left on mobile
  • small CKEditor style improvements

@jiromaykin jiromaykin force-pushed the fix/2169-mailtemplate-stylings branch from e14aee4 to e3e5e50 Compare March 5, 2024 11:03
@jiromaykin jiromaykin marked this pull request as ready for review March 5, 2024 11:04
@jiromaykin jiromaykin force-pushed the fix/2169-mailtemplate-stylings branch from e3e5e50 to 9e64595 Compare March 5, 2024 12:44
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (c677c1d) to head (b9f4322).

❗ Current head b9f4322 differs from pull request most recent head 3e80445. Consider uploading reports for the commit 3e80445 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1072   +/-   ##
========================================
  Coverage    95.00%   95.00%           
========================================
  Files          894      894           
  Lines        31404    31405    +1     
========================================
+ Hits         29834    29835    +1     
  Misses        1570     1570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the fix/2169-mailtemplate-stylings branch from 3e09fff to 0b843cc Compare March 5, 2024 14:42
@jiromaykin jiromaykin requested a review from Bartvaderkin March 5, 2024 14:52
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Template language should be consistent

@@ -17,5 +17,5 @@
</table>

<p><a href="{{ plan_list_link }}">Go to your plans</a></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the text be Dutch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but this PR for #2169 is really only about styling and about the 3 case_status templates; I'd rather change all the 'other templates properly in task #2120 - I just wanted to do a small correction for the paragraphs here.

@jiromaykin jiromaykin requested a review from pi-sigma March 7, 2024 13:16
@jiromaykin jiromaykin force-pushed the fix/2169-mailtemplate-stylings branch 2 times, most recently from ce745ac to 3e80445 Compare March 7, 2024 14:04
@alextreme
Copy link
Member

Mag gemerged worden na verhelpen conflict

@jiromaykin jiromaykin force-pushed the fix/2169-mailtemplate-stylings branch from 3e80445 to ced91f7 Compare March 11, 2024 10:15
@alextreme alextreme merged commit a0afa39 into develop Mar 11, 2024
15 checks passed
@alextreme alextreme deleted the fix/2169-mailtemplate-stylings branch March 11, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants