Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Avoid necessary fields redirect for media files #1061

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

stevenbal
Copy link
Contributor

Same fix as #1052, forgot to apply it to NecessaryFieldsMiddleware

@stevenbal
Copy link
Contributor Author

@alextreme I figured that until we change this middleware setup, it would be good to make sure this doesn't happen in the current setup

@stevenbal stevenbal requested a review from alextreme February 29, 2024 10:39
@alextreme alextreme requested review from Bartvaderkin and removed request for alextreme February 29, 2024 13:18
@alextreme
Copy link
Member

I guess this only applies for dev-environments (as static files are served by Nginx). Can be checked by Bart and merged imho

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth development is worth it.

@Bartvaderkin Bartvaderkin merged commit 7abc38d into develop Feb 29, 2024
15 checks passed
@Bartvaderkin Bartvaderkin deleted the fix/registration-redirect-staticfiles branch February 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants