Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔒 [#2130] Obfuscate incorrect password in Axes logs #1053

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Feb 26, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2130\

after this is merged, I'll make PRs to default-project and OF

@stevenbal stevenbal requested a review from alextreme February 26, 2024 08:37
@stevenbal stevenbal force-pushed the fix/2130-axes-hide-incorrect-password branch 2 times, most recently from 77393b0 to e09e910 Compare February 26, 2024 08:45
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.92%. Comparing base (6282dd5) to head (eb23276).
Report is 7 commits behind head on develop.

❗ Current head eb23276 differs from pull request most recent head e09e910. Consider uploading reports for the commit e09e910 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1053   +/-   ##
========================================
  Coverage    94.92%   94.92%           
========================================
  Files          882      882           
  Lines        30863    30864    +1     
========================================
+ Hits         29298    29299    +1     
  Misses        1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gebruik van AXES_SENSITIVE_PARAMETERS (denk ik)

@alextreme alextreme merged commit e54631a into develop Feb 27, 2024
15 checks passed
@alextreme alextreme deleted the fix/2130-axes-hide-incorrect-password branch February 27, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants