🗑️ [#2062] Remove dashboard templatetags #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1051 +/- ##
===========================================
- Coverage 94.92% 94.92% -0.01%
===========================================
Files 882 880 -2
Lines 30863 30841 -22
===========================================
- Hits 29298 29276 -22
Misses 1565 1565 ☔ View full report in Codecov by Sentry. |
pi-sigma
approved these changes
Feb 23, 2024
| <aside class="faq" aria-label="{% trans "Veelgestelde vragen" %}"> | ||
| {% if title %}<h2 id="faq" class="h2">{{ title }}</h2>{% endif %} | ||
| {% trans "Veelgestelde vragen" as default_title %} | ||
| <aside class="faq" aria-label="{{ default_title }}"> |
There was a problem hiding this comment.
Is there a point for the aria-label? Either the h2 is visible, then the content is accessible to screen readers, or the h2 is hidden, but then the h1 element from pages/faq.html is visible and contains {% trans "Veelgestelde vragen" %}, so again the content is accessible.
There was a problem hiding this comment.
Hmm I'm not sure, @jiromaykin can we omit the aria-label here?
There was a problem hiding this comment.
aria-label on an 'aside' has very mixed support and here it seems redundant
Bartvaderkin
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.