[#2026] KVK branch selection

[jiromaykin]

issue https://taiga.maykinmedia.nl/project/open-inwoner/task/2026
design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=481-4737&mode=design&t=Rf5MsQFFdwpCVUqV-0

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (53a9201) to head (de88960).
Report is 12 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1043      +/-   ##
===========================================
+ Coverage    94.95%   94.99%   +0.03%     
===========================================
  Files          892      892              
  Lines        31203    31375     +172     
===========================================
+ Hits         29630    29805     +175     
+ Misses        1573     1570       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jiromaykin]

@pi-sigma @stevenbal with this one I am not quite sure how to deal with the KVK data, since I cannot retrieve a 'housenumber' - also I am not quite sure if there are companies that do not have ANY Hoofdvestiging at all?

If I show all branches including the Hoofdvestiging, then at least the tests are passing through...

I commented out the template for separating the Hoofdvestiging from all the Nevenvestiging branches since that would need a rework for the tests + I am not sure how to combine both options logically
(1. only show all branches in 1 list if there is no Hoofdvestiging,
2. IF Hoofdvestiging exists: show a separate List-item for Hoofdvestiging and group only the List-items for Nevenvestigingen),
here you can see the differences between both:

[pi-sigma]

I'll take a closer look later/tomorrow and see if we need to make changes in the backend in order to support the split template.

About the house number/letter and other data: is this an explicit request from the client or something the designer(s) assumed would make sense?

[pi-sigma]

The branch without vestigingsnummer is not the hoofdvestging, but a pseudo-branch that we create to represent the company as a whole. The hoofdvestiging is one vestiging among others, and as such it also has a vestigingsnummer.

[stevenbal]

That's right, maybe we should define the "entire company" option outside of company_branches to avoid confusion? Or would that make the form more complicated?

[jiromaykin]

@pi-sigma I've left he commented-out code for the split-template still in it, for future use ;
It's all inside one large unordered-list.
feel free to approve this one and/or make changes in this PR itself.

[stevenbal]

@jiromaykin I could modify it to use the split template, I'll approve and assign the PR to myself 👍

[jiromaykin]

... About the house number/letter and other data: is this an explicit request from the client or something the designer(s) assumed would make sense?

I am just trying to mimic the design - and I don't know how much of it is a 'hard requirement' - perhaps @alextreme knows more about what to include.

[stevenbal]

That's right, maybe we should define the "entire company" option outside of company_branches to avoid confusion? Or would that make the form more complicated?

[stevenbal]

It does seem there is some location info being passed, you could access it with {{ branch.adres.binnenlandsAdres.straatnaam }} but it doesn't have huisnummers unfortunately:

   {
      "adres":{
         "binnenlandsAdres":{
            "plaats":"Lollum",
            "straatnaam":"Hizzaarderlaan",
            "type":"bezoekadres"
         }
      },
      "kvkNummer":"68750110",
      "links":[
         {
            "href":"https://api.kvk.nl/test/api/v1/basisprofielen/68750110",
            "rel":"basisprofiel"
         },
         {
            "href":"https://api.kvk.nl/test/api/v1/vestigingsprofielen/000037178598",
            "rel":"vestigingsprofiel"
         }
      ],
      "naam":"Test BV Donald",
      "type":"hoofdvestiging",
      "vestigingsnummer":"000037178598"
   },
   

@pi-sigma if we want the full address for each vestiging we might have to do separate calls to /v1/vestigingsprofielen/<vestigingsnummer>?

[stevenbal]

with this one I am not quite sure how to deal with the KVK data, since I cannot retrieve a 'housenumber' - also I am not quite sure if there are companies that do not have ANY Hoofdvestiging at all?

@jiromaykin I think that every company in the KVK data has a hoofdvestiging with its own vestigingsnummer different from the KVK nummer (even if it is the only vestiging)

I feel like it would be a bit unnecessary to display both the "entire company" option and the hoofdvestiging option, if there are no other vestigingen though

[alextreme]

... About the house number/letter and other data: is this an explicit request from the client or something the designer(s) assumed would make sense?

I am just trying to mimic the design - and I don't know how much of it is a 'hard requirement' - perhaps @alextreme knows more about what to include.

@jiromaykin showing the adres of a vestiging isn't a requirement, if not (easily) possible please ask Jacki to modify the design accordingly

[stevenbal]

I modified the template to split the "entire company" option from the other branches, added the adress info (without housenumber, because that's not present in the data) and added (hoofdvestiging) to indicate that the first branch option is the hoofdvestiging:

Nevenvestiging is part of the name of the branch in the test KVK API, so that can be ignored