[#2118] Add links in email template, improve padding #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextreme
reviewed
Feb 15, 2024
| @@ -49,7 +49,7 @@ <h2>{{ type_description }}</h2> | |||
| <tr> | |||
| <td class="td-mail td-mail__bg-info td__padding-all td__info-link" colspan="6"> | |||
| <p>U hoeft niets te doen. Zodra er weer een update beschikbaar is ontvangt u hier een melding over. U kunt wel inloggen om uw aanvraag te bekijken.</p> | |||
| <p><strong><a href="{{ case_link }}" class="color--primary">Log in</a><span class="color--primary"> →</span></strong></p> | |||
There was a problem hiding this comment.
The case_link is preferable, this gives you a redirect to the loginpage with a next-parameter to the detailview of the case
alextreme
reviewed
Feb 15, 2024
| @@ -46,7 +46,7 @@ <h2>{{ type_description }}</h2> | |||
| <tr> | |||
| <td class="td-mail td-mail__bg-danger td__padding-all" colspan="6"> | |||
| <p>Log in om de documenten te uploaden.</p> | |||
| <a href="{{ case_link }}" class="button--primary">Log in</a> | |||
| <p><a href="{{ login_page }}" class="button--primary">Log in</a></p> | |||
There was a problem hiding this comment.
Also here case_link would be preferable
|
Opting to merge & correct both links in develop, this to ensure we get adequate feedback for the templates |
alextreme
approved these changes
Feb 15, 2024
jiromaykin
commented
Mar 5, 2024
| <td class="td-mail td__padding-all" colspan="6"> | ||
| <p>Pas hier uw <a href="https://example.com">voorkeuren</a> aan voor de notificaties. </p> | ||
| <td class="td-mail td__padding-right td__padding-bottom td__padding-left" colspan="6"> | ||
| <p>Pas hier uw <a href="{{ profile_notifications }}">voorkeuren</a> aan voor de notificaties. </p> |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2118