Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2062] Remove condition and contact tags #1018

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

pi-sigma
Copy link
Contributor

Taiga: #2062

Two small components

@pi-sigma pi-sigma force-pushed the cleanup/2062-templatetags branch 2 times, most recently from 2bc16b2 to 2103b39 Compare February 16, 2024 14:14
@pi-sigma pi-sigma marked this pull request as ready for review February 16, 2024 15:00
@pi-sigma pi-sigma requested a review from stevenbal February 16, 2024 15:00
@pi-sigma pi-sigma force-pushed the cleanup/2062-templatetags branch from 2103b39 to 7f4ebe6 Compare February 16, 2024 15:02
@pi-sigma
Copy link
Contributor Author

@stevenbal Tests didn't pass when I included only a subset of arguments with the contact form template because of the missing csrfmiddlewaretoken.

@pi-sigma pi-sigma force-pushed the cleanup/2062-templatetags branch from 7f4ebe6 to bb60031 Compare February 16, 2024 17:16
@@ -1,9 +1,9 @@
{% extends 'master.html' %}
{% load i18n contact_tags %}
{% load i18n solo_tags %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solo_tags needed here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I forgot the tag when I moved the config to the view.

Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about a tag include

@pi-sigma pi-sigma force-pushed the cleanup/2062-templatetags branch from bb60031 to 4bfcdf7 Compare February 19, 2024 15:46
@stevenbal stevenbal merged commit 4b33e05 into develop Feb 20, 2024
15 checks passed
@stevenbal stevenbal deleted the cleanup/2062-templatetags branch February 20, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants