Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏪ [#2096] Re-add selected categories for users #1012

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Feb 8, 2024

task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2096

I kept the template for the view the same as it was before:

image

The card under my profile is updated to be in line with the design:

image

@stevenbal stevenbal marked this pull request as draft February 8, 2024 13:42
@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch 2 times, most recently from 22b53cd to 035fd86 Compare February 8, 2024 14:23
@stevenbal stevenbal marked this pull request as ready for review February 8, 2024 14:25
@stevenbal stevenbal requested a review from alextreme February 8, 2024 14:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fefb1f5) 94.74% compared to head (72de4fa) 94.75%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1012      +/-   ##
===========================================
+ Coverage    94.74%   94.75%   +0.01%     
===========================================
  Files          872      874       +2     
  Lines        30571    30644      +73     
===========================================
+ Hits         28965    29038      +73     
  Misses        1606     1606              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme
Copy link
Member

Dit werd in het profiel volgens mij wel getoond als "Mijn Interessegebieden" ipv "Mijn Onderwerpen"

@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from 035fd86 to 72de4fa Compare February 9, 2024 08:29
@stevenbal
Copy link
Contributor Author

@alextreme ik heb het veranderd naar Mijn Interessegebieden

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hieraan nog ontbreekt is dat we de gekozen onderwerpen ook tonen op de homepage via het CMS (dus via de CategoriesPlugin).

Werkwijze daarin zou volgens mij moeten zijn dat als je je interessegebieden hebt aangevinkt, dat die en alleen die onderwerpen op je homepage te zien zijn. Als je ze allemaal hebt uitgevinkt dan zou je weer terug moeten gaan naar het tonen van de gehighlighte onderwerpen

@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from 72de4fa to 7405e55 Compare February 12, 2024 10:26
@stevenbal stevenbal requested a review from alextreme February 12, 2024 10:29
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id attribute for the selected categories should be changed, though I don't know if it's even needed.

@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from 7405e55 to 6809520 Compare February 12, 2024 13:56
@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch 2 times, most recently from a834907 to b2f1050 Compare February 19, 2024 13:20
@stevenbal
Copy link
Contributor Author

@pi-sigma can you re-review this? :)

@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from b2f1050 to f45608d Compare February 22, 2024 13:27
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Card titles should now all be actual heading tags :-)
and one small minor thing: we should slowly stop using "h1, h2, h4" classes etc. But that is a long ongoing process.

@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from f45608d to 06170ae Compare February 23, 2024 08:58
@stevenbal stevenbal requested a review from jiromaykin February 23, 2024 08:59
@stevenbal stevenbal force-pushed the feature/2096-restore-mijn-interesses branch from 06170ae to df3b5ee Compare February 26, 2024 10:33
@stevenbal stevenbal requested a review from jiromaykin February 26, 2024 10:33
@stevenbal stevenbal requested review from alextreme and removed request for alextreme February 26, 2024 11:09
@alextreme alextreme merged commit 2263994 into develop Feb 26, 2024
15 checks passed
@alextreme alextreme deleted the feature/2096-restore-mijn-interesses branch February 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants