-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⏪ [#2096] Re-add selected categories for users #1012
Conversation
22b53cd
to
035fd86
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1012 +/- ##
===========================================
+ Coverage 94.74% 94.75% +0.01%
===========================================
Files 872 874 +2
Lines 30571 30644 +73
===========================================
+ Hits 28965 29038 +73
Misses 1606 1606 ☔ View full report in Codecov by Sentry. |
Dit werd in het profiel volgens mij wel getoond als "Mijn Interessegebieden" ipv "Mijn Onderwerpen" |
035fd86
to
72de4fa
Compare
@alextreme ik heb het veranderd naar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We hieraan nog ontbreekt is dat we de gekozen onderwerpen ook tonen op de homepage via het CMS (dus via de CategoriesPlugin).
Werkwijze daarin zou volgens mij moeten zijn dat als je je interessegebieden hebt aangevinkt, dat die en alleen die onderwerpen op je homepage te zien zijn. Als je ze allemaal hebt uitgevinkt dan zou je weer terug moeten gaan naar het tonen van de gehighlighte onderwerpen
72de4fa
to
7405e55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The id
attribute for the selected categories should be changed, though I don't know if it's even needed.
7405e55
to
6809520
Compare
a834907
to
b2f1050
Compare
@pi-sigma can you re-review this? :) |
b2f1050
to
f45608d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Card titles should now all be actual heading tags :-)
and one small minor thing: we should slowly stop using "h1, h2, h4" classes etc. But that is a long ongoing process.
f45608d
to
06170ae
Compare
06170ae
to
df3b5ee
Compare
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2096
I kept the template for the view the same as it was before:
The card under my profile is updated to be in line with the design: