-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 [#2081] add profile-edit page designs #1008
Conversation
996ce72
to
3262aad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1008 +/- ##
========================================
Coverage 94.91% 94.91%
========================================
Files 882 882
Lines 30748 30748
========================================
Hits 29183 29183
Misses 1565 1565 ☔ View full report in Codecov by Sentry. |
7cba72f
to
291967a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question about mobile view for profile edit page
291967a
to
47c8b89
Compare
f426b20
to
c9cf858
Compare
@stevenbal I removed the back-buttons now because the designer has to update the design; apparently those buttons need to become a single breadcrumb that will just show the 'current' page in the breadcrumb view - but for that we would need to further discuss and open a new issue. |
fd450a9
to
adea6f1
Compare
issue https://taiga.maykinmedia.nl/project/open-inwoner/task/2081
➕ this PR also solves issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2082
Add back-buttons+ add correct icon in My profiel + add new designs for edit-profile and view BRP/digid profile-data.http://localhost:8000/mijn-profiel/
http://localhost:8000/mijn-profiel/edit/
http://localhost:8000/mijn-profiel/mydata/
➕ added new class for fullwidth buttons in forms
Designs: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=3%3A6398&mode=design&t=VNpvkCkb7m5lhpIq-1
Note: we do not have Tablet designs yet for any pages with a sidebar...