Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#2081] add profile-edit page designs #1008

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Feb 8, 2024

issue https://taiga.maykinmedia.nl/project/open-inwoner/task/2081
➕ this PR also solves issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2082
Add back-buttons + add correct icon in My profiel + add new designs for edit-profile and view BRP/digid profile-data.
http://localhost:8000/mijn-profiel/
http://localhost:8000/mijn-profiel/edit/
http://localhost:8000/mijn-profiel/mydata/
➕ added new class for fullwidth buttons in forms

Designs: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=3%3A6398&mode=design&t=VNpvkCkb7m5lhpIq-1

Note: we do not have Tablet designs yet for any pages with a sidebar...

@jiromaykin jiromaykin changed the title {#2081} add profile-edit page designs 💄 [#2081] add profile-edit page designs Feb 8, 2024
@jiromaykin jiromaykin force-pushed the feature/2081-add-profile-page-designs branch 2 times, most recently from 996ce72 to 3262aad Compare February 13, 2024 07:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (651f7cd) 94.91% compared to head (f426b20) 94.91%.

❗ Current head f426b20 differs from pull request most recent head 3f29cb5. Consider uploading reports for the commit 3f29cb5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1008   +/-   ##
========================================
  Coverage    94.91%   94.91%           
========================================
  Files          882      882           
  Lines        30748    30748           
========================================
  Hits         29183    29183           
  Misses        1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiromaykin jiromaykin force-pushed the feature/2081-add-profile-page-designs branch 3 times, most recently from 7cba72f to 291967a Compare February 19, 2024 15:57
@jiromaykin jiromaykin marked this pull request as ready for review February 19, 2024 15:57
@jiromaykin jiromaykin requested review from pi-sigma and stevenbal and removed request for pi-sigma February 19, 2024 16:34
Copy link
Contributor

@stevenbal stevenbal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question about mobile view for profile edit page

@jiromaykin jiromaykin force-pushed the feature/2081-add-profile-page-designs branch from 291967a to 47c8b89 Compare February 20, 2024 11:33
@jiromaykin jiromaykin force-pushed the feature/2081-add-profile-page-designs branch from f426b20 to c9cf858 Compare February 20, 2024 16:54
@jiromaykin
Copy link
Contributor Author

@stevenbal I removed the back-buttons now because the designer has to update the design; apparently those buttons need to become a single breadcrumb that will just show the 'current' page in the breadcrumb view - but for that we would need to further discuss and open a new issue.

@jiromaykin jiromaykin requested a review from stevenbal February 20, 2024 17:55
@jiromaykin jiromaykin force-pushed the feature/2081-add-profile-page-designs branch from fd450a9 to adea6f1 Compare February 22, 2024 14:50
@jiromaykin jiromaykin requested a review from stevenbal February 22, 2024 15:04
@stevenbal stevenbal merged commit a5f3ea5 into develop Feb 23, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/2081-add-profile-page-designs branch February 23, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants