Skip to content

Commit

Permalink
Merge pull request #465 from maykinmedia/fix/1124-upload-uppercase-ex…
Browse files Browse the repository at this point in the history
…tension

[#1124] Support uppercase extensions in case detail document file upload
  • Loading branch information
alextreme authored Feb 9, 2023
2 parents 3bdf500 + 560a9e0 commit da891a7
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/open_inwoner/accounts/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ def clean_file(self):
f"Een aangeleverd bestand dient maximaal {config.max_upload_size} MB te zijn, uw bestand is te groot."
)

if file_extension.replace(".", "") not in allowed_extensions:
if file_extension.lower().replace(".", "") not in allowed_extensions:
raise ValidationError(
f"Het type bestand dat u hebt geüpload is ongeldig. Geldige bestandstypen zijn: {', '.join(allowed_extensions)}"
)
Expand Down
29 changes: 29 additions & 0 deletions src/open_inwoner/openzaak/tests/test_case_detail.py
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,35 @@ def test_successful_document_upload_flow(self, m):
),
)

def test_successful_document_upload_flow_with_uppercase_extension(self, m):
self._setUpMocks(m)

zaak_type_config = ZaakTypeConfigFactory(
identificatie=self.zaaktype["identificatie"]
)
zaak_type_iotc = ZaakTypeInformatieObjectTypeConfigFactory(
zaaktype_config=zaak_type_config,
informatieobjecttype_url=self.informatie_object["url"],
zaaktype_uuids=[self.zaaktype["uuid"]],
document_upload_enabled=True,
)

response = self.app.get(self.case_detail_url, user=self.user)
form = response.forms["document-upload"]
form["title"] = "uploaded file"
form["type"] = zaak_type_iotc.id
form["file"] = Upload("upload.TXT", b"data", "text/plain")
form_response = form.submit()

redirect = form_response.follow()
redirect_messages = list(redirect.context["messages"])

self.assertRedirects(form_response, self.case_detail_url)
self.assertEqual(
redirect_messages[0].message,
_("upload.TXT has been successfully uploaded"),
)

def test_upload_file_flow_fails_with_invalid_file_extension(self, m):
self._setUpMocks(m)

Expand Down

0 comments on commit da891a7

Please sign in to comment.