[#559] Updated logging

maykinmedia · May 13, 2022 · b475e6a · b475e6a
1 parent 89673fb
commit b475e6a
Show file tree

Hide file tree

Showing 18 changed files with 593 additions and 106 deletions.
diff --git a/src/open_inwoner/accounts/signals.py b/src/open_inwoner/accounts/signals.py
@@ -5,16 +5,27 @@
 
 from open_inwoner.utils.logentry import user_action
 
+MESSAGE_TYPE = {
+    "admin": _("user was logged in via admin page"),
+    "frontend_email": _("user was logged in via frontend using email"),
+    "frontend_digid": _("user was logged in via frontend using digid"),
+    "logout": _("user was logged out"),
+}
+
 
 @receiver(user_logged_in)
 def log_user_login(sender, user, request, *args, **kwargs):
-    if request.path.startswith(reverse("admin:login")):
-        user_action(request, user, _("user was logged in via admin page"))
+    current_path = request.path
+
+    if current_path == reverse("admin:login"):
+        user_action(request, user, MESSAGE_TYPE["admin"])
+    elif current_path == reverse("digid:acs"):
+        user_action(request, user, MESSAGE_TYPE["frontend_digid"])
     else:
-        user_action(request, user, _("user was logged in via frontend"))
+        user_action(request, user, MESSAGE_TYPE["frontend_email"])
 
 
 @receiver(user_logged_out)
 def log_user_logout(sender, user, request, *args, **kwargs):
     if user:
-        user_action(request, user, _("user was logged out"))
+        user_action(request, user, MESSAGE_TYPE["logout"])