[#2671] fix QR code appearance in dark mode #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a57cc85 to
382bfa5
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 47 47
Lines 2342 2342
Branches 170 230 +60
=======================================
Hits 2244 2244
Misses 74 74
Partials 24 24 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
382bfa5 to
fe52f84
Compare
sergei-maertens
requested changes
Feb 14, 2023
sergei-maertens
requested changes
Feb 14, 2023
.github/workflows/ci.yml
Outdated
| @@ -46,7 +46,7 @@ jobs: | |||
| - name: Generate coverage XML report | |||
| run: coverage xml | |||
| - name: Codecov | |||
| uses: codecov/codecov-action@v1.0.10 | |||
| uses: codecov/codecov-action@v1.5.2 | |||
There was a problem hiding this comment.
wasn't there a v3 already? I think we use that in the open forms backend
.github/workflows/ci.yml
Outdated
| @@ -10,7 +10,7 @@ jobs: | |||
| continue-on-error: ${{ matrix.experimental == 'true' }} | |||
| strategy: | |||
| matrix: | |||
| python-version: ['3.6', '3.7', '3.8'] | |||
| python-version: ['3.8', '3.9', '3.10', '3.11'] | |||
| django-version: ['2.2', '3.0', '3.1'] | |||
There was a problem hiding this comment.
2.2 is end of life, so are 3.0 and 3.1. We should only support 3.2 (and 4.2 in a couple of weeks when it releases)
tox.ini
Outdated
Comment on lines
5
to
6
| py{38,39,310,311}-dj22-{normal,yubikey,custom_user}, | ||
| py{38,39,310,311}-dj30-{normal,yubikey,custom_user}, | ||
| py{38,39,310,311}-dj31-{normal,yubikey,custom_user}, | ||
| py{38,39,310,311}-djmaster-{normal,yubikey,custom_user} |
There was a problem hiding this comment.
this build matrix also needs updating for proper django 3.2+ env, take a look at https://github.com/maykinmedia/drf-polymorphic/blob/main/tox.ini#L3 for example
fe52f84 to
2d74459
Compare
* white background was missing from the CSS * drop support for Python < 3.8 and Django < 3.2
2d74459 to
bbde9a5
Compare
sergei-maertens
approved these changes
Feb 15, 2023
|
decided against updating this fork and instead we'll tackle things in OF directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-formulieren/open-forms#2671
styleattribute to theimgtag with the QR code to add white background