Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task and management command for cleaning up logs #28

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Oct 2, 2023

Open-Inwoner Taiga #1773

Closes #7

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Merging #28 (ef93d52) into main (272d3e9) will decrease coverage by 0.34%.
The diff coverage is 92.59%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   98.06%   97.73%   -0.34%     
==========================================
  Files          19       20       +1     
  Lines         414      441      +27     
  Branches       55       57       +2     
==========================================
+ Hits          406      431      +25     
- Misses          5        6       +1     
- Partials        3        4       +1     
Files Coverage Δ
log_outgoing_requests/conf.py 100.00% <100.00%> (ø)
...management/commands/prune_outgoing_request_logs.py 100.00% <100.00%> (ø)
log_outgoing_requests/tasks.py 89.47% <100.00%> (+7.65%) ⬆️
log_outgoing_requests/models.py 97.64% <81.81%> (-2.36%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pi-sigma pi-sigma force-pushed the feature/cleanup-logs branch 2 times, most recently from a015e49 to 680a647 Compare October 2, 2023 13:39
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the documentation updates that a management command and celery task for pruning exist.

@pi-sigma pi-sigma force-pushed the feature/cleanup-logs branch 2 times, most recently from 1f635c0 to b418289 Compare October 3, 2023 09:38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a thought I had yesterday, late - the command is now invoked with manage.py prune_logs which is a far too generic name. It would be confusing and possibly colliding with a similarly named command from another library (say django-timeline-logger, for example).

I'd rename the command to prune_outgoing_request_logs

@pi-sigma pi-sigma force-pushed the feature/cleanup-logs branch from b418289 to ef93d52 Compare October 4, 2023 18:28
@sergei-maertens sergei-maertens merged commit f24e9e5 into main Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move periodic "purge records" implementation to the library
3 participants