-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add task and management command for cleaning up logs #28
Conversation
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 98.06% 97.73% -0.34%
==========================================
Files 19 20 +1
Lines 414 441 +27
Branches 55 57 +2
==========================================
+ Hits 406 431 +25
- Misses 5 6 +1
- Partials 3 4 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a015e49
to
680a647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing the documentation updates that a management command and celery task for pruning exist.
log_outgoing_requests/management/commands/cleanup_requests_logs.py
Outdated
Show resolved
Hide resolved
log_outgoing_requests/management/commands/cleanup_requests_logs.py
Outdated
Show resolved
Hide resolved
1f635c0
to
b418289
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a thought I had yesterday, late - the command is now invoked with manage.py prune_logs
which is a far too generic name. It would be confusing and possibly colliding with a similarly named command from another library (say django-timeline-logger, for example).
I'd rename the command to prune_outgoing_request_logs
b418289
to
ef93d52
Compare
Open-Inwoner Taiga #1773
Closes #7