Extend/refactor OIDC configuration for DigiD/eHerkenning #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sergei-maertens
commented
Jun 12, 2024
- Added support for dots in claim names
- Added extra configuration fields to be able to capture the full authentication context
Version 0.18.0 will have the ClaimFieldDefault utility that we rely on.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 90.12% 90.41% +0.29%
==========================================
Files 50 50
Lines 1569 1576 +7
Branches 142 141 -1
==========================================
+ Hits 1414 1425 +11
+ Misses 114 110 -4
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
13803e5 to
e920f95
Compare
sergei-maertens
commented
Jun 12, 2024
stevenbal
requested changes
Jun 13, 2024
The existing string-fields are now migrated to claim fields so that dots in claim names are supported. Additionally, the fields have been renamed to better cover their meaning, in line with the authentication context data model/json schema.
From the test accounts/connections analysis, it became clear that additional information needs to be extracted from the OIDC claims. This sets up the relevant configuration fields to be able to specify which claims hold which data.
Ensure that the renamed/moved and new fields are present in the admin configuration forms.
This code is not directly consumed in any of our backends, and that makes testing it hard too. The consuming code is (and belongs) in Open Forms.
Downstream projects will miss/forget this, and we know which claims hold privacy-sensitive information.
247490c to
04242ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.